Skip to content

resource/aws_route53_record: Normalizes Resource Identity name to fully-qualified domain name#48848

Open
gdavison wants to merge 27 commits into
mainfrom
td-no-read-in-list-route53-record
Open

resource/aws_route53_record: Normalizes Resource Identity name to fully-qualified domain name#48848
gdavison wants to merge 27 commits into
mainfrom
td-no-read-in-list-route53-record

Conversation

@gdavison

@gdavison gdavison commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Normalizes name in Resource Identity to fully-qualified domain name.

Removes resource Read function from aws_route53_record List.

Output from Acceptance Testing

% make testacc PKG=route53 TESTS=TestAccRoute53Record_

--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (165.85s)
--- PASS: TestAccRoute53Record_List_wildcard (196.84s)
--- PASS: TestAccRoute53Record_Alias_s3 (211.62s)
--- PASS: TestAccRoute53Record_Alias_uppercase (211.65s)
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (215.03s)
--- PASS: TestAccRoute53Record_Alias_elb (217.53s)
--- PASS: TestAccRoute53Record_Allow_overwrite (227.67s)
--- PASS: TestAccRoute53Record_Identity_basic (228.24s)
--- PASS: TestAccRoute53Record_Identity_wildcard (233.08s)
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (252.56s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (257.83s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (263.58s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityCoordinates (265.05s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (265.06s)
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (265.40s)
--- PASS: TestAccRoute53Record_typeChange_allowOverwrite (281.66s)
--- PASS: TestAccRoute53Record_nameChange (294.96s)
--- PASS: TestAccRoute53Record_ttl0 (298.79s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityLocalZoneGroup (189.62s)
--- PASS: TestAccRoute53Record_longTXTrecord (148.63s)
--- PASS: TestAccRoute53Record_empty (151.75s)
--- PASS: TestAccRoute53Record_List_shortName (146.19s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geoproximityRegion (193.19s)
--- PASS: TestAccRoute53Record_List_trailingDot_includeResource (142.08s)
--- PASS: TestAccRoute53Record_List_trailingDot (142.19s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (194.49s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (194.64s)
--- PASS: TestAccRoute53Record_List_shortName_includeResource (147.24s)
--- PASS: TestAccRoute53Record_escapedSpace (148.43s)
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (421.57s)
--- PASS: TestAccRoute53Record_escapedJustSpace (145.71s)
--- PASS: TestAccRoute53Record_Alias_changeDualstack (200.04s)
--- PASS: TestAccRoute53Record_Alias_change (202.45s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (193.87s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (193.93s)
--- PASS: TestAccRoute53Record_Identity_Upgrade_ShortName (184.65s)
--- PASS: TestAccRoute53Record_Identity_ChangeOnUpdate (190.02s)
--- PASS: TestAccRoute53Record_Identity_ShortName (161.82s)
--- PASS: TestAccRoute53Record_basic_ShortName (152.71s)
--- PASS: TestAccRoute53Record_Identity_TrailingDot (162.42s)
--- PASS: TestAccRoute53Record_aliasWildcardName (534.05s)
--- PASS: TestAccRoute53Record_List_fullName (144.59s)
--- PASS: TestAccRoute53Record_List_fullName_includeResource (143.67s)
--- PASS: TestAccRoute53Record_Identity_SetIdentifier (165.97s)
--- PASS: TestAccRoute53Record_escapedSlash (152.20s)
--- PASS: TestAccRoute53Record_basic_FullName (157.82s)
--- PASS: TestAccRoute53Record_Latency_basic (156.00s)
--- PASS: TestAccRoute53Record_Support_caa (152.72s)
--- PASS: TestAccRoute53Record_Weighted_basic (161.09s)
--- PASS: TestAccRoute53Record_failover (160.99s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (207.91s)
--- PASS: TestAccRoute53Record_generatesSuffix (147.66s)
--- PASS: TestAccRoute53Record_typeChange (201.89s)
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (196.22s)
--- PASS: TestAccRoute53Record_Support_ds (148.58s)
--- PASS: TestAccRoute53Record_wildcard (201.52s)
--- PASS: TestAccRoute53Record_List_wildcard_includeResource (143.93s)
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (200.95s)
--- PASS: TestAccRoute53Record_Geoproximity_basic (158.42s)
--- PASS: TestAccRoute53Record_Identity_ExistingResource_noRefreshNoChange (185.16s)
--- PASS: TestAccRoute53Record_Geolocation_basic (163.35s)
--- PASS: TestAccRoute53Record_Support_txt (159.80s)
--- PASS: TestAccRoute53Record_Support_spf (155.86s)
--- PASS: TestAccRoute53Record_underscored (145.58s)
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (167.23s)
--- PASS: TestAccRoute53Record_disappears (147.21s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (201.74s)
--- PASS: TestAccRoute53Record_fqdn (180.99s)
--- PASS: TestAccRoute53Record_Identity_ExistingResource_basic (193.22s)
--- PASS: TestAccRoute53Record_cidr (277.61s)
--- PASS: TestAccRoute53Record_Weighted_alias (276.76s)

@gdavison gdavison requested a review from a team as a code owner July 8, 2026 21:26
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/M Managed by automation to categorize the size of a PR. labels Jul 8, 2026
Base automatically changed from td-no-read-in-list-lambda-layer_version to main July 9, 2026 19:52
@gdavison gdavison marked this pull request as draft July 9, 2026 19:58
gdavison added 19 commits July 9, 2026 15:15
@gdavison
Adds checks for name and fqdn for name with trailing dot
ab8bfd0
@gdavison
Adds RI test for name with trailing dot
4c8c81c
@gdavison
Adds basic test with short name
3b0ad89
@gdavison
Uses correct domain and subdomain names
0877ec2
@gdavison
Updates resource name
81aea1d
@gdavison
Fixes resource address
bc53582
@gdavison
Uses normalized fqdn for name attribute in Resource Identity
91e9e36
@gdavison
Missed value
79bb91c
@gdavison
Separates domain and subdomain variables. Avoids use of .com domain…
3036265 
… names
@gdavison
Clarifies that fqdn trims trailing ., if any
685995c
@gdavison
Moves fqdn handling to resourceRecordFlatten
0aae777
@gdavison
Ensures _basic List tests don't have trailing .
05ea61b
@gdavison
Fixes RI from List
7ac7db2
@gdavison
Includes record type in display name
1e653e2
@gdavison
Adds check for name in _includeResource test
cd178a3
@gdavison
Renames List tests
2a221ff
@gdavison
Adds List tests for short name
0776d15
@gdavison
Adds List tests for name with trailing dot
ad75722
@gdavison
Removes unused return value
2801a08
@gdavison gdavison mentioned this pull request Jul 10, 2026
Open
26 tasks
@github-actions github-actions Bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 10, 2026
@gdavison gdavison changed the title list resource/aws_route53_record: Removes resource Read function from List resource/aws_route53_record: Normalizes name to fully-qualified domain name Jul 10, 2026
@gdavison gdavison changed the title resource/aws_route53_record: Normalizes name to fully-qualified domain name resource/aws_route53_record: Normalizes Resource Identity name to fully-qualified domain name Jul 10, 2026
@gdavison gdavison marked this pull request as ready for review July 11, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/route53 Issues and PRs that pertain to the route53 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gdavison